climbing: Add climbing restriction + show authors on routes #404
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -100,6 +101,8 @@ export const FeaturePanelInner = () => { | |||
| <FeatureHeading /> | |||
| <ParentLink /> | |||
|
|
|||
| <ClimbingRestriction /> | |||
There was a problem hiding this comment.
@zbycz what about this? I know it shouldn't be here because it's generic FeaturePanel, but where to put it if it's for all features with climbing tag?
There was a problem hiding this comment.
It is OK to have parts of feature panel, which are rendered only sometimes.
In future we could extend FeaturedTags to accomodate this, or even extend iD tagging scheme.
jvaclavik
changed the title
| @@ -55,6 +55,7 @@ export const osmToClimbingRoutes = (feature: Feature): Array<ClimbingRoute> => { | |||
| difficulty: getDifficulty(route.tags), | |||
| paths, | |||
| photoToKeyMap, | |||
| author: route.tags.author, | |||
There was a problem hiding this comment.
Can you use feature.tags.author instead of adding a new field? We will have to move all of it nevertheless.
There was a problem hiding this comment.
I wanted but it needs broader refactoring. Right now we have temp object for editing with ClimbingRoute type, so this whole needs to be refactored.
jvaclavik
force-pushed
the
climbing-add-author-and-restriction
branch
from
61a0e5d
to
94e082e
Compare
climbing not allowed on crag
climbing not allowed on area
climbing restricted on crag
